ashb commented on code in PR #47065:
URL: https://github.com/apache/airflow/pull/47065#discussion_r1971519649
##########
airflow/models/taskinstancehistory.py:
##########
@@ -58,7 +59,12 @@ class TaskInstanceHistory(Base):
"""
__tablename__ = "task_instance_history"
- id = Column(Integer(), primary_key=True, autoincrement=True)
+ id = Column(Integer, primary_key=True, autoincrement=True)
+ task_instance_id = Column(
+ String(36).with_variant(postgresql.UUID(as_uuid=False), "postgresql"),
+ nullable=False,
+ )
+ try_id = Column(UUIDType(binary=False), nullable=False, unique=True)
Review Comment:
I don't like this on the history table - the try_id seems like the perfect
primary key for this table
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
