eladkal commented on code in PR #47146:
URL: https://github.com/apache/airflow/pull/47146#discussion_r1974171105


##########
task_sdk/src/airflow/sdk/definitions/baseoperator.py:
##########
@@ -956,6 +957,25 @@ def __init__(
         self.email_on_retry = email_on_retry
         self.email_on_failure = email_on_failure
 
+        if email is not None:
+            warnings.warn(
+                "email is deprecated please migrate to SmtpNotifier`.",
+                RemovedInAirflow4Warning,
+                stacklevel=2,
+            )
+        if email and email_on_retry is not None:

Review Comment:
   We must have it because `email_on_retry` has default True and we don't want 
to change the default.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to