pierrejeambrun commented on code in PR #47180:
URL: https://github.com/apache/airflow/pull/47180#discussion_r1977551549
##########
airflow/ui/src/components/ParseDag.tsx:
##########
@@ -30,10 +31,19 @@ const ParseDag = ({ dagId, fileToken }: Props) => {
const { isPending, mutate } = useDagParsing({ dagId });
return (
- <Button loading={isPending} onClick={() => mutate({ fileToken })}
variant="outline">
- <AiOutlineFileSync height={5} width={5} />
- Reparse Dag
- </Button>
+ <Box>
Review Comment:
Weird, is that from the latest branch or a specific browse ? If I try on my
end I don't see the issue after removing the box of `ParseDag`
Anyway that might come from the `display` prop of the button. If you play
with the `display: flex` that should be enough for this to work. (You might
end-up with `flex-inline` or something).
Non blocking.
##########
airflow/ui/src/components/ParseDag.tsx:
##########
@@ -30,10 +31,19 @@ const ParseDag = ({ dagId, fileToken }: Props) => {
const { isPending, mutate } = useDagParsing({ dagId });
return (
- <Button loading={isPending} onClick={() => mutate({ fileToken })}
variant="outline">
- <AiOutlineFileSync height={5} width={5} />
- Reparse Dag
- </Button>
+ <Box>
Review Comment:
Weird, is that from the latest branch or a specific browse ? If I try on my
end I don't see the issue after removing the box of `ParseDag`?
Anyway that might come from the `display` prop of the button. If you play
with the `display: flex` that should be enough for this to work. (You might
end-up with `flex-inline` or something).
Non blocking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
