TJaniF commented on code in PR #47354:
URL: https://github.com/apache/airflow/pull/47354#discussion_r1989573799
##########
task_sdk/src/airflow/sdk/definitions/dag.py:
##########
@@ -402,7 +404,9 @@ def __rich_repr__(self):
validator=attrs.validators.optional(attrs.validators.instance_of(timedelta)),
)
# sla_miss_callback: None | SLAMissCallback | list[SLAMissCallback] = None
- catchup: bool = attrs.field(default=True, converter=bool)
+ catchup: bool = attrs.field(
+ default=airflow_conf.getboolean("scheduler", "catchup_by_default"),
converter=bool
+ )
Review Comment:
Changed it to that, recreating the funtion, after a conversation with @ashb
:)
##########
task_sdk/src/airflow/sdk/definitions/dag.py:
##########
@@ -402,7 +404,9 @@ def __rich_repr__(self):
validator=attrs.validators.optional(attrs.validators.instance_of(timedelta)),
)
# sla_miss_callback: None | SLAMissCallback | list[SLAMissCallback] = None
- catchup: bool = attrs.field(default=True, converter=bool)
+ catchup: bool = attrs.field(
+ default=airflow_conf.getboolean("scheduler", "catchup_by_default"),
converter=bool
+ )
Review Comment:
Changed it to that, recreating the function, after a conversation with @ashb
:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
