[ 
https://issues.apache.org/jira/browse/AIRFLOW-5641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949882#comment-16949882
 ] 

ASF GitHub Bot commented on AIRFLOW-5641:
-----------------------------------------

houqp commented on pull request #6312: [AIRFLOW-5641] support running git sync 
container as root
URL: https://github.com/apache/airflow/pull/6312
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow 
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references 
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-5641
   
   ### Description
   
   Fixed a regression that prevents user from using root as user for git sync 
container.
   
   Also changed `_get_security_context_val` so that it behaves as documented. 
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   See changed files in tests folder
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes 
how to use it.
     - All the public functions and the classes in the PR contain docstrings 
that explain what it does
     - If you implement backwards incompatible changes, please leave a note in 
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so 
we can assign it to a appropriate release
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Not able to run git sync init container as root
> -----------------------------------------------
>
>                 Key: AIRFLOW-5641
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5641
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: executor-kubernetes
>    Affects Versions: 2.0.0
>            Reporter: QP Hou
>            Assignee: QP Hou
>            Priority: Critical
>
> We used to be able to run git sync init container as root user. A recent 
> refactoring of the code base (AIRFLOW-4851) introduced a regression that 
> makes it impossible to run git sync container as root. As a result, we are 
> not able to start any task using kubernetes executor.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to