pierrejeambrun commented on code in PR #47690: URL: https://github.com/apache/airflow/pull/47690#discussion_r1993356619
########## airflow/api_fastapi/core_api/routes/public/dag_tags.py: ########## @@ -34,13 +35,14 @@ ) from airflow.api_fastapi.common.router import AirflowRouter from airflow.api_fastapi.core_api.datamodels.dag_tags import DAGTagCollectionResponse +from airflow.api_fastapi.core_api.security import ReadableTagsFilterDep, requires_access_dag from airflow.models.dag import DagTag dag_tags_router = AirflowRouter(tags=["DAG"], prefix="/dagTags") @dag_tags_router.get( - "", + "", dependencies=[Depends(requires_access_dag(method="GET", access_entity=DagAccessEntity.CODE))] Review Comment: I would say that a new entity might be overkill. Dags information contains tag anyway and we can only GET tags. So let's go for Dag. If later we can edit / create tag without going through the dag entity maybe a new entity will make sense then -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
