ashb commented on code in PR #47731:
URL: https://github.com/apache/airflow/pull/47731#discussion_r1993751908
##########
task-sdk/src/airflow/sdk/execution_time/supervisor.py:
##########
@@ -445,17 +448,22 @@ def _register_pipe_readers(self, stdout: socket, stderr:
socket, requests: socke
# alternatives are used automatically) -- this is a way of having
"event-based" code, but without
# needing full async, to read and process output from each socket as
it is received.
- self.selector.register(stdout, selectors.EVENT_READ,
self._create_socket_handler(self.log, "stdout"))
+ target_loggers: tuple[FilteringBoundLogger, ...] = (self.log,)
+ if self.verbose_logs_to_main_logger:
+ target_loggers += (log,)
Review Comment:
`self.log` is the process specific logger, which is configured to write to
the file.
`log` is the top level module scoped generic logger.
Would renaming `self.log` to `self.process_log` or `process_logger` help do
you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
