tirkarthi commented on code in PR #47732:
URL: https://github.com/apache/airflow/pull/47732#discussion_r1993800136


##########
task-sdk/src/airflow/sdk/log.py:
##########
@@ -229,12 +229,18 @@ def json_processor(logger: Any, method_name: Any, 
event_dict: EventDict) -> str:
 @cache
 def configure_logging(
     enable_pretty_log: bool = True,
-    log_level: str = "DEBUG",
+    log_level: str = "DEFAULT",

Review Comment:
   Just curious why not below. I see this pattern of checking in `sys.modules` 
and then importing in task-sdk and other places. Importing 
`airflow.configuration` on top level could make the module loading slower and 
directly doing local import helps is my understanding but just confused on 
checking `sys.modules` .
   
   ```python
   log_level: str = "DEFAULT"
   
   if log_level == "DEFAULT":
       from airflow.configuration import conf
       log_level = conf.get("logging", "logging_level", fallback="INFO")



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to