vincbeck commented on code in PR #47691:
URL: https://github.com/apache/airflow/pull/47691#discussion_r1996317717
##########
airflow/cli/cli_parser.py:
##########
@@ -55,47 +55,52 @@
CLICommand,
)
-airflow_commands = core_commands.copy() # make a copy to prevent bad
interactions in tests
-
-log = logging.getLogger(__name__)
+def get_commands():
Review Comment:
Very good callout :) I'll rollback this and left it at module level. To be
honest I thought there was no particular reason to do it at the module level so
I wanted to "improve" the code as well. But since there is a valid reason, I'll
put it back at module level and use `reload` in tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
