jedcunningham commented on code in PR #47837:
URL: https://github.com/apache/airflow/pull/47837#discussion_r1998860497
##########
airflow/cli/commands/remote_commands/task_command.py:
##########
@@ -231,7 +231,13 @@ def task_failed_deps(args) -> None:
Trigger Rule: Task's trigger rule 'all_success' requires all upstream tasks
to have succeeded, but found 1 non-success(es).
"""
- dag = get_dag(args.subdir, args.dag_id)
+ dag = _parse_and_get_dag(args.dag_id)
Review Comment:
This should just use serialized dag from the db, not reparse it on the fly
like this.
##########
airflow/cli/commands/remote_commands/task_command.py:
##########
@@ -255,7 +261,13 @@ def task_state(args) -> None:
>>> airflow tasks state tutorial sleep 2015-01-01
success
"""
- dag = get_dag(args.subdir, args.dag_id)
+ dag = _parse_and_get_dag(args.dag_id)
Review Comment:
Same here.
##########
airflow/cli/commands/remote_commands/task_command.py:
##########
@@ -266,7 +278,13 @@ def task_state(args) -> None:
@providers_configuration_loaded
def task_list(args, dag: DAG | None = None) -> None:
"""List the tasks within a DAG at the command line."""
- dag = dag or get_dag(args.subdir, args.dag_id)
+ dag = dag or _parse_and_get_dag(args.dag_id)
Review Comment:
And here.
##########
airflow/cli/commands/remote_commands/task_command.py:
##########
@@ -421,8 +444,13 @@ def task_test(args, dag: DAG | None = None, session:
Session = NEW_SESSION) -> N
@providers_configuration_loaded
def task_render(args, dag: DAG | None = None) -> None:
"""Render and displays templated fields for a given task."""
+ dag = dag or _parse_and_get_dag(args.dag_id)
Review Comment:
And here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
