aritra24 commented on code in PR #47790:
URL: https://github.com/apache/airflow/pull/47790#discussion_r2000957555
##########
airflow/ui/src/queries/useCreateBackfill.ts:
##########
@@ -50,7 +50,7 @@ export const useCreateBackfill = ({ onSuccessConfirm }: {
onSuccessConfirm: () =
const dataIntervalEnd = new Date(data.requestBody.to_date);
const dagId = data.requestBody.dag_id;
- if (!Boolean(dataIntervalStart) || !Boolean(dataIntervalEnd)) {
+ if (isNaN(dataIntervalStart.getTime()) ||
isNaN(dataIntervalEnd.getTime())) {
Review Comment:
When I mention malformed here it can mostly only be either a date or an
empty string (When no date is selected at start time), so I can maybe change
the check to just a not empty string check...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
