pierrejeambrun commented on code in PR #47760:
URL: https://github.com/apache/airflow/pull/47760#discussion_r2003735800
##########
airflow/api_fastapi/auth/managers/simple/ui/dev/index.html:
##########
@@ -3,7 +3,7 @@
<html lang="en" style="height: 100%">
<head>
<meta charset="UTF-8" />
- <link rel="icon" type="image/png"
href="http://localhost:5174/public/pin_32.png"; />
+ <link rel="icon" type="image/png"
href="http://localhost:5174/api/v2/pin_32.png"; />
Review Comment:
Ash is right. Maybe no prefix is a good alternative for static files.
##########
tests/api_fastapi/core_api/routes/public/test_auth.py:
##########
@@ -46,7 +46,7 @@ class TestGetLogin(TestAuthEndpoint):
],
)
def test_should_respond_307(self, test_client, params):
- response = test_client.get("/public/auth/login",
follow_redirects=False, params=params)
+ response = test_client.get("/api/v2/auth/login",
follow_redirects=False, params=params)
Review Comment:
Yes it would be a nice factorization. Could be a follow up PR too so it
doesn't add too much effort for this PR.
##########
airflow/ui/src/mocks/handlers/log.ts:
##########
@@ -21,7 +21,7 @@
import { http, HttpResponse, type HttpHandler } from "msw";
export const handlers: Array<HttpHandler> = [
-
http.get("/public/dags/log_grouping/dagRuns/manual__2025-02-18T12:19/taskInstances/generate/-1",
() =>
+
http.get("/api/v2/dags/log_grouping/dagRuns/manual__2025-02-18T12:19/taskInstances/generate/-1",
() =>
Review Comment:
That's a good idea yes. I would suggest do that in a follow up PR though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
![http://localhost:5174/public/pin_32.png"](http://localhost:5174/public/pin_32.png"){kind=link}
![http://localhost:5174/api/v2/pin_32.png"](http://localhost:5174/api/v2/pin_32.png"){kind=link}