ashb commented on a change in pull request #6090: [AIRFLOW-5470] Add Apache Livy REST operator URL: https://github.com/apache/airflow/pull/6090#discussion_r334399646
########## File path: airflow/contrib/operators/livy_operator.py ########## @@ -0,0 +1,178 @@ +# -*- coding: utf-8 -*- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +""" +This module contains the Apache Livy operator. +""" + +from time import sleep + +from airflow.contrib.hooks.livy_hook import BatchState, LivyHook +from airflow.exceptions import AirflowException +from airflow.models import BaseOperator +from airflow.utils.decorators import apply_defaults + + +class LivyOperator(BaseOperator): + """ + This operator wraps the Apache Livy batch REST API, allowing to submit a Spark + application to the underlying cluster. + + :param file: path of the file containing the application to execute (required). + :type file: str + :param class_name: name of the application Java/Spark main class. + :type class_name: str + :param args: application command line arguments. + :type args: list + :param jars: jars to be used in this sessions. + :type jars: list + :param py_files: python files to be used in this session. + :type py_files: list + :param files: files to be used in this session. + :type files: list + :param driver_memory: amount of memory to use for the driver process. + :type driver_memory: str + :param driver_cores: number of cores to use for the driver process. + :type driver_cores: str + :param executor_memory: amount of memory to use per executor process. + :type executor_memory: str + :param executor_cores: number of cores to use for each executor. + :type executor_cores: str + :param num_executors: number of executors to launch for this session. + :type num_executors: str + :param archives: archives to be used in this session. + :type archives: list + :param queue: name of the YARN queue to which the application is submitted. + :type queue: str + :param name: name of this session. + :type name: str + :param conf: Spark configuration properties. + :type conf: dict + :param proxy_user: user to impersonate when running the job. + :type proxy_user: str + :param livy_conn_id: reference to a pre-defined Livy Connection. + :type livy_conn_id: str + :param polling_interval: time in seconds between polling for job completion. Don't poll for values >=0 + :type polling_interval: int + :param timeout: when greater than zero, seconds to wait for a terminal state before killing the batch. + :type timeout: int + """ + + @apply_defaults + def __init__( + self, + file=None, + class_name=None, + args=None, + conf=None, + jars=None, + py_files=None, + files=None, + driver_memory=None, + driver_cores=None, + executor_memory=None, + executor_cores=None, + num_executors=None, + archives=None, + queue=None, + name=None, + proxy_user=None, + livy_conn_id='livy_default', + polling_interval=0, + **kwargs + ): + # pylint: disable-msg=too-many-arguments + + super(LivyOperator, self).__init__(**kwargs) + + self._spark_params = { + 'file': file, + 'class_name': class_name, + 'args': args, + 'jars': jars, + 'py_files': py_files, + 'files': files, + 'driver_memory': driver_memory, + 'driver_cores': driver_cores, + 'executor_memory': executor_memory, + 'executor_cores': executor_cores, + 'num_executors': num_executors, + 'archives': archives, + 'queue': queue, + 'name': name, + 'conf': conf, + 'proxy_user': proxy_user + } + + self._livy_conn_id = livy_conn_id + self._polling_interval = polling_interval + + self._livy_hook = None + self._batch_id = None + + def get_hook(self): + """ + Get valid hook. + + :return: hook + :rtype: LivyHook + """ + if self._livy_hook and isinstance(self._livy_hook, LivyHook): + self.log.info("livy_conn_id is ignored when Livy hook is already provided") + return self._livy_hook + + return LivyHook(livy_conn_id=self._livy_conn_id) + + def execute(self, context): + self._livy_hook = self.get_hook() + + self._batch_id = self._livy_hook.post_batch(**self._spark_params) + + if self._polling_interval > 0: + self.poll_for_termination(self._batch_id) + + return self._batch_id + + def poll_for_termination(self, batch_id): + """ + Pool Livy for batch termination. + + :param batch_id: id of the batch session to monitor. + :type batch_id: int + """ + state = self._livy_hook.get_batch_state(batch_id) + while state not in self._livy_hook.TERMINAL_STATES: + self.log.debug('Batch with id %s is in state: %s', batch_id, state.value) + sleep(self._polling_interval) + state = self._livy_hook.get_batch_state(batch_id) + self.log.info("Batch with id %s terminated with state: %s", batch_id, state.value) + if state != BatchState.SUCCESS: + raise AirflowException("Batch did not succeed") + + def on_kill(self): + self.kill() + + def kill(self): + """ + Delete the current batch session. + """ + if self._batch_id is not None: + self._livy_hook.delete_batch(self._batch_id) + else: + raise AirflowException("Missing batch session id") Review comment: I don't think we should raise here -- it probably just means the kill happened before the execute got a chance to do anything. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services