o-nikolas commented on code in PR #47968:
URL: https://github.com/apache/airflow/pull/47968#discussion_r2004239496
##########
providers/amazon/src/airflow/providers/amazon/aws/transfers/redshift_to_s3.py:
##########
@@ -102,7 +103,7 @@ def __init__(
table: str | None = None,
select_query: str | None = None,
redshift_conn_id: str = "redshift_default",
- aws_conn_id: str | None = "aws_default",
+ aws_conn_id: str | None | ArgNotSet = NOTSET,
Review Comment:
Because I'm trying to keep a couple things true at the same time:
1) Don't make a breaking change, this is basically the tl;dr answer to your
question. So far this operator has been inserting that connection id, and there
could be many dags out there that are happily working with this default. So if
I now make it None, that will break for those users.
2) None is a value the user could supply, and I'm really trying to detect
the case where they don't supply anything. (but again 1/ is mostly the issue).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
