eladkal commented on code in PR #48008:
URL: https://github.com/apache/airflow/pull/48008#discussion_r2006087332
##########
providers/amazon/src/airflow/providers/amazon/aws/notifications/sns.py:
##########
@@ -20,8 +20,8 @@
from collections.abc import Sequence
from functools import cached_property
-from airflow.notifications.basenotifier import BaseNotifier
from airflow.providers.amazon.aws.hooks.sns import SnsHook
+from airflow.providers.common.compat.nofitier import BaseNotifier
Review Comment:
I think we need this under try/catch as users may run aws provider with
several versions of `common.compat` (not necessarily the latest) and similar
with all other providers
```
# remove try catch when min version of common.compat in the provider is 1.6.0
try:
from airflow.providers.common.compat.nofitier import BaseNotifier
except ImportError:
from airflow.notifications.basenotifier import BaseNotifier
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
