potiuk commented on code in PR #47957:
URL: https://github.com/apache/airflow/pull/47957#discussion_r2006632282
##########
providers/docker/tests/unit/docker/operators/test_docker_swarm.py:
##########
@@ -124,7 +125,7 @@ def _client_service_logs_effect():
assert len(csargs) == 1, "create_service called with different number
of arguments than expected"
assert csargs == (mock_obj,)
assert cskwargs["labels"] == {"name":
"airflow__adhoc_airflow__unittest"}
- assert cskwargs["name"].startswith("airflow-")
+ assert cskwargs["name"].startswith("swarm-service")
Review Comment:
can we parameterize that test and make few different cases ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
