bugraoz93 commented on code in PR #47985:
URL: https://github.com/apache/airflow/pull/47985#discussion_r2006453611
##########
hatch_build.py:
##########
@@ -236,7 +236,9 @@
"opentelemetry-exporter-otlp>=1.24.0",
"packaging>=23.2",
"pathspec>=0.9.0",
- "platformdirs>=4.3.6",
+ # platformdirs installs setuptools 77.0.1 which seems to break distutils
+ # excluding that version for now, remove this comment and limitation if
new version is installed and fixes it
+ "platformdirs>=4.3.6,!=4.3.7",
Review Comment:
I have added `platformdirs` for the CLI API communication. This is now moved
under `airflow-ctl/`. We can remove it safely. I have double-checked the usage
and it is not used in core. Thanks for the fix! We should update it here
https://github.com/apache/airflow/blob/b2216e6114f13b0f5eae45904d0b636e75a8438e/airflow-ctl/pyproject.toml#L31.
I can do the change if you don't have time, I will touch those parts anyway,
feel free :)
##########
hatch_build.py:
##########
@@ -236,7 +236,9 @@
"opentelemetry-exporter-otlp>=1.24.0",
"packaging>=23.2",
"pathspec>=0.9.0",
- "platformdirs>=4.3.6",
+ # platformdirs installs setuptools 77.0.1 which seems to break distutils
+ # excluding that version for now, remove this comment and limitation if
new version is installed and fixes it
+ "platformdirs>=4.3.6,!=4.3.7",
Review Comment:
I have added `platformdirs` for the CLI API communication. This is now moved
under `airflow-ctl/`. We can remove it safely. I have double-checked the usage
and it is not used in core. Thanks for the fix! We should update it here
https://github.com/apache/airflow/blob/b2216e6114f13b0f5eae45904d0b636e75a8438e/airflow-ctl/pyproject.toml#L31
I can make the change if you don't have time, I will touch those parts
anyway, feel free :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
