[ 
https://issues.apache.org/jira/browse/AIRFLOW-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16951054#comment-16951054
 ] 

ASF subversion and git services commented on AIRFLOW-5387:
----------------------------------------------------------

Commit 2ed422a0c969594f52fec6248b617250b8863930 in airflow's branch 
refs/heads/v1-10-test from Alejandro Rojas
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=2ed422a ]

[AIRFLOW-5387] Fix show paused pagination bug (#6100)

(cherry picked from commit 93bb5e44d8ede09d3301f29de15121901ba010f4)


> Pagination is broken when the config variable hide_paused_dags_by_default is 
> set to True because showPaused variable is removed
> -------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-5387
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5387
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: ui
>    Affects Versions: 1.10.4
>            Reporter: Guillem Lefait
>            Assignee: Alejandro
>            Priority: Minor
>             Fix For: 1.10.6
>
>
> Url parameters are clean to remove useless parameters:
> {code:python}
> // https://github.com/apache/airflow/blob/master/airflow/www/utils.py#L68-L71
>     if 'showPaused' in kwargs:
>       v = kwargs['showPaused']
>       if v or v is None:
>          kwargs.pop('showPaused')
> {code}
> When the configuration variable _hide_paused_dags_by_default_ is set to True, 
> removing the parameter showPaused disable access to the correct paginated 
> pages when navigating to "Show Paused DAGs" .
> Pagination is fine for the first page but when going on second page, only 
> "active" DAGs are presented.
> Fix: 
> - showPaused parameter should not be removed and therefore lines 68 to 71 
> (included) could be removed.
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to