eladkal commented on code in PR #47993:
URL: https://github.com/apache/airflow/pull/47993#discussion_r2009738047
##########
providers/apache/beam/src/airflow/providers/apache/beam/operators/beam.py:
##########
@@ -37,14 +37,13 @@
from airflow.providers.apache.beam.triggers.beam import
BeamJavaPipelineTrigger, BeamPythonPipelineTrigger
from airflow.providers.google.cloud.hooks.dataflow import (
DataflowHook,
- DataflowJobStatus,
process_line_and_extract_dataflow_job_id_callback,
)
from airflow.providers.google.cloud.hooks.gcs import GCSHook, _parse_gcs_url
from airflow.providers.google.cloud.links.dataflow import DataflowJobLink
from airflow.providers.google.cloud.operators.dataflow import CheckJobRunning,
DataflowConfiguration
from airflow.providers.google.cloud.triggers.dataflow import (
- DataflowJobStatusTrigger,
+ DataflowJobStateCompleteTrigger,
Review Comment:
This import is not guaranteed to work.
Beam provider may be executed with older versions of google provider.
You need to modify the beam code to support both older and newer versions of
Google provider
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
