pierrejeambrun commented on code in PR #48189:
URL: https://github.com/apache/airflow/pull/48189#discussion_r2010241604


##########
airflow-core/src/airflow/ui/src/pages/XCom/XCom.tsx:
##########
@@ -34,6 +36,49 @@ const columns: Array<ColumnDef<XComResponse>> = [
     enableSorting: false,
     header: "Key",
   },
+  {
+    accessorKey: "dag_id",

Review Comment:
   dag_id, run_id, and task_id are always defined. (which is not the case for 
the Event datamodel). We don't need to handle null case here.
   
   ```
   class XComResponse(BaseModel):
       """Serializer for a xcom item."""
   
       key: str
       timestamp: datetime
       logical_date: datetime | None
       map_index: int
       task_id: str
       dag_id: str
       run_id: str
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to