[
https://issues.apache.org/jira/browse/AIRFLOW-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16951830#comment-16951830
]
ASF GitHub Bot commented on AIRFLOW-5621:
-----------------------------------------
bharathpalaksha commented on pull request #6335: [AIRFLOW-5621] - Failure
callback is not triggered when marked Failed on UI
URL: https://github.com/apache/airflow/pull/6335
Make sure you have checked all steps below.
Jira
My PR addresses the following Airflow Jira issues and references them in
the PR title.
Description
When a task is marked 'Failed' on UI, on_failure_callback on the task is
not triggered.
Tests
My PR adds the following unit tests
test_mark_failure_on_failure_callback
Commits
My commits all reference Jira issues in their subject lines, and I have
squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "How to write a good git commit message":
Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> When task is marked as failed through UI, failure callback is not triggered
> ---------------------------------------------------------------------------
>
> Key: AIRFLOW-5621
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5621
> Project: Apache Airflow
> Issue Type: Bug
> Components: core
> Affects Versions: 1.10.2
> Reporter: Bharath Palaksha
> Assignee: Bharath Palaksha
> Priority: Major
>
> When you mark a task as failed - Worker detects and kills the process but -
> on_failure_callback is not honoured.
> on_failure_callback needs to be called to complete it's intended
> functionality.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
