ashb commented on a change in pull request #5743: [AIRFLOW-5088][AIP-24]
Persisting serialized DAG in DB for webserver scalability
URL: https://github.com/apache/airflow/pull/5743#discussion_r334887153
##########
File path: airflow/models/baseoperator.py
##########
@@ -1021,8 +1039,8 @@ def xcom_pull(
@cached_property
def extra_links(self) -> Iterable[str]:
"""@property: extra links for the task. """
- return list(set(self.operator_extra_link_dict.keys())
- .union(self.global_operator_extra_link_dict.keys()))
+ return sorted(list(set(self.operator_extra_link_dict.keys())
Review comment:
We might not need the set either - dicts can't have duplicate keys
```suggestion
return sorted(self.operator_extra_link_dict.keys())
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
