Soot3 commented on code in PR #48442:
URL: https://github.com/apache/airflow/pull/48442#discussion_r2016911718


##########
airflow-core/src/airflow/ui/src/pages/Pools/Pools.tsx:
##########
@@ -32,8 +33,17 @@ export const Pools = () => {
   const [searchParams, setSearchParams] = useSearchParams();
   const { NAME_PATTERN: NAME_PATTERN_PARAM }: SearchParamsKeysType = 
SearchParamsKeys;
   const [poolNamePattern, setPoolNamePattern] = 
useState(searchParams.get(NAME_PATTERN_PARAM) ?? undefined);
+  
+  const { tableURLState } = useTableURLState();

Review Comment:
   @bbovenzi Oh i saw that. would the rest of the datatable structure be needed 
as well and integrated to the poolbar mapping that is available now.  for 
example 
[here](https://github.com/apache/airflow/blob/87c55b51457bf9dafbcbf541ff51940f0455fd15/airflow/ui/src/pages/Variables/Variables.tsx)
 `<DataTable
             columns={columns}
             data={data ? data.variables : []}
             errorMessage={<ErrorAlert error={error} />}
             initialState={tableURLState}
             isFetching={isFetching}
             isLoading={isLoading}
             modelName="Variable"
             onStateChange={setTableURLState}
             total={data ? data.total_entries : 0}
           />
         </Box>`  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to