jscheffl commented on code in PR #48109:
URL: https://github.com/apache/airflow/pull/48109#discussion_r2017601835
##########
airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_connections.py:
##########
@@ -390,7 +401,13 @@ def test_should_respond_403(self,
unauthorized_test_client):
"body, updated_connection, update_mask",
[
(
- {"connection_id": TEST_CONN_ID, "conn_type": TEST_CONN_TYPE,
"extra": '{"key": "var"}'},
+ {
+ "connection_id": TEST_CONN_ID,
+ "conn_type": TEST_CONN_TYPE,
+ "extra": '{"key": "var"}',
+ "login": TEST_CONN_LOGIN,
+ "port": TEST_CONN_PORT,
+ },
Review Comment:
Okay, I assume not it is considered- as discussed in 1:1 slack - that body
fields are only set as provided when no update mask provided.
Extended pytest on this to catch a regression as well, was not fully covered
in tests before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
