amoghrajesh commented on code in PR #48526:
URL: https://github.com/apache/airflow/pull/48526#discussion_r2019775608
##########
task-sdk/src/airflow/sdk/execution_time/task_runner.py:
##########
@@ -343,7 +343,10 @@ def xcom_pull(
map_index=m_idx,
include_prior_dates=include_prior_dates,
)
- xcoms.append(value if value else default)
+ if value is None:
+ xcoms.append(default)
+ else:
+ xcoms.append(value)
Review Comment:
Anyways, good catch!
##########
task-sdk/src/airflow/sdk/execution_time/task_runner.py:
##########
@@ -343,7 +343,10 @@ def xcom_pull(
map_index=m_idx,
include_prior_dates=include_prior_dates,
)
- xcoms.append(value if value else default)
+ if value is None:
+ xcoms.append(default)
+ else:
+ xcoms.append(value)
Review Comment:
Very interesting that this could cause breakage!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
