ashb commented on code in PR #48597:
URL: https://github.com/apache/airflow/pull/48597#discussion_r2021789480


##########
airflow-core/src/airflow/api_fastapi/auth/tokens.py:
##########
@@ -451,7 +451,7 @@ def generate(self, extras: dict[str, Any] | None = None, 
headers: dict[str, Any]
             del claims["aud"]
 
         if extras is not None:
-            claims.update(extras)
+            claims = extras | claims

Review Comment:
   This is to not overwrite anything in claims with values from extra -- i.e. 
if `extra` includes  "exp" etc we don't want to use it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to