tirkarthi commented on PR #48636:
URL: https://github.com/apache/airflow/pull/48636#issuecomment-2770001254

   I think it's still useful to show the source of the event in asset detail 
page. Maybe below was the intention of the PR change to hide name instead of 
the source.
   
   ```patch
   diff --git 
a/airflow-core/src/airflow/ui/src/components/Assets/AssetEvent.tsx 
b/airflow-core/src/airflow/ui/src/components/Assets/AssetEvent.tsx
   index adfd2e125c..fff67542d8 100644
   --- a/airflow-core/src/airflow/ui/src/components/Assets/AssetEvent.tsx
   +++ b/airflow-core/src/airflow/ui/src/components/Assets/AssetEvent.tsx
   @@ -55,7 +55,7 @@ export const AssetEvent = ({
          <Text fontWeight="bold">
            <Time datetime={event.timestamp} />
          </Text>
   -      {Boolean(assetId) ? undefined : (
   +      {Boolean(assetId) && !Boolean(showAssetName) ? undefined : (
            <HStack>
              <FiDatabase />
              <Tooltip
   @@ -73,7 +73,6 @@ export const AssetEvent = ({
              </Tooltip>
            </HStack>
          )}
   -      {Boolean(showAssetName) ? (
            <HStack>
              <Text>Source: </Text>
              {source === "" ? (
   @@ -86,7 +85,6 @@ export const AssetEvent = ({
                source
              )}
            </HStack>
   -      ) : undefined}
          <HStack>
            <TriggeredRuns dagRuns={event.created_dagruns} />
          </HStack>
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to