aritra24 commented on code in PR #48644: URL: https://github.com/apache/airflow/pull/48644#discussion_r2028170411
########## airflow-core/src/airflow/ui/src/pages/Configs/Configs.tsx: ########## @@ -0,0 +1,71 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { Heading, Separator } from "@chakra-ui/react"; +import type { ColumnDef } from "@tanstack/react-table"; + +import { useConfigServiceGetConfig } from "openapi/queries"; +import type { ConfigOption } from "openapi/requests/types.gen"; +import { DataTable } from "src/components/DataTable"; +import { ErrorAlert } from "src/components/ErrorAlert"; + +type ConfigColums = { + section: string; +} & ConfigOption; + +const columns: Array<ColumnDef<ConfigColums>> = [ + { + accessorKey: "section", + enableSorting: false, + header: () => "section", Review Comment: I had done this to start off, but I'm not fully sure why (probably based on the content size) the tables were rendering with different column widths (the image attached earlier is of that) and it didn't look very good. Though I do agree this view with all sections rendered is too long as well. In the older airflow 2 this is how it looked so I tried it out. But perhaps we can try something cleaner. I can see if I can add something in the data table to force certain column widths? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
