eladkal commented on code in PR #48008: URL: https://github.com/apache/airflow/pull/48008#discussion_r2006096858
########## providers/amazon/src/airflow/providers/amazon/aws/notifications/sns.py: ########## @@ -20,8 +20,8 @@ from collections.abc import Sequence from functools import cached_property -from airflow.notifications.basenotifier import BaseNotifier from airflow.providers.amazon.aws.hooks.sns import SnsHook +from airflow.providers.common.compat.nofitier import BaseNotifier Review Comment: If we don't set minimum version of common.compat to Airflow 3 https://github.com/apache/airflow/blob/b757bd8df824d4eba952f6e140bcb373bc3f1003/hatch_build.py#L43 we might need to do something like ``` # remove try catch when min version of common.compat in the provider is 1.6.0 try: from airflow.providers.common.compat.nofitier import BaseNotifier except ImportError: if AIRFLOW_V_3_0_PLUS: raise AirflowOptionalProviderFeatureException( "Failed to import BaseNotifier. Please install common.compat provider version >=1.6.0 ) else: from airflow.notifications.basenotifier import BaseNotifier ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
