potiuk commented on code in PR #48223: URL: https://github.com/apache/airflow/pull/48223#discussion_r2020226574
########## dev/breeze/pyproject.toml: ########## Review Comment: Yes. I think it will be fine to move it, but for now it's highly disruptive move for everyone and I wanted to discuss it on the devlist and make this move first, I just do not want too many "pieces" on the board to move at the same time. I think moving `breeze` should be **just breeze** with well tested instructions on how to move. Especially for peopl who are back-porting stuff to `v2-10-test` it is highly disruptive move if not carefully done. The problem is that currrently how cherry-picker works is that it has to start with the `main` branch and end with `v2-10-test` branch and then if you resolve conflict, it will attempt to run pre-commits - some of them via breeze. it basicallly means that if `breeze` is installed from `main` and you switch to `v2-10-test` while cherry-picking all hell will break loose with pre-commits if we do not handle it gracefully. I see two options of what could be done (hinted about it in the description): 1) moving `breeze` to top-level (as `airflow-breeze` and leaving `dev` where it is 2) merging `dev` and `devel-common` together and moving breeze to `airflow-breeze` I kinda like that all the distributions of ours are top-level and have `-` in them, becaue that automatically makes forbids accidental imports starting from the repository root, also `dev` and `devel-common` seem to be pretty difficult to explain. But also maybe other names could be used here, so I wanted to discuss it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
