pierrejeambrun commented on code in PR #47994:
URL: https://github.com/apache/airflow/pull/47994#discussion_r2035814557
##########
airflow-core/src/airflow/ui/src/components/TaskName.tsx:
##########
@@ -51,15 +51,31 @@ export const TaskName = ({
// We don't have a task group details page to link to
if (isGroup) {
return (
- <Text fontSize="md" fontWeight="bold" {...rest}>
+ <Text
+ fontSize="md"
+ fontWeight="bold"
+ style={{
+ WebkitBoxOrient: "vertical",
+ WebkitLineClamp: 1,
+ }}
+ {...rest}
+ >
{label}
{isMapped ? " [ ]" : undefined}
</Text>
);
}
return (
- <Text fontSize={isZoomedOut ? "lg" : "md"} fontWeight="bold" {...rest}>
+ <Text
+ fontSize={isZoomedOut ? "lg" : "md"}
+ fontWeight="bold"
+ style={{
+ WebkitBoxOrient: "vertical",
Review Comment:
What’s the rational behind using only WebKit css props, and not the default
ones ?
##########
airflow-core/src/airflow/ui/src/layouts/Details/Grid/Grid.tsx:
##########
@@ -71,11 +71,11 @@ export const Grid = ({ limit }: Props) => {
);
return (
- <Flex justifyContent="flex-end" position="relative" pt={50} width="100%">
- <Box position="absolute" top="150px" width="100%">
+ <Flex justifyContent="flex-start" position="relative" pt={50} width="100%">
+ <Box mr="10px" position="relative" top="100px">
Review Comment:
mr={3}
Chakra standardise such value 3 = 9px I think, which is the closest to 10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
