ashb commented on code in PR #49045:
URL: https://github.com/apache/airflow/pull/49045#discussion_r2037398504
##########
airflow-core/src/airflow/models/taskinstance.py:
##########
@@ -411,13 +411,21 @@ def _stop_remaining_tasks(*, task_instance: TaskInstance,
session: Session):
TaskInstanceState.FAILED,
):
continue
- task = task_instance.task.dag.task_dict[ti.task_id]
- if not task.is_teardown:
+ if task_teardown_map:
+ teardown = task_teardown_map[ti.task_id]
+ else:
+ task = task_instance.task.dag.task_dict[ti.task_id]
+ teardown = task.is_teardown
+ if not teardown:
if ti.state == TaskInstanceState.RUNNING:
log.info("Forcing task %s to fail due to dag's `fail_fast`
setting", ti.task_id)
+ msg = f"Forcing task {ti.task_id} to fail due to `fail_fast`
property set in the dag"
Review Comment:
We don't need `ti.task_id` in the log message, it's already associated with
the TI via the task_instance=ti.key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
