github-advanced-security[bot] commented on code in PR #49195:
URL: https://github.com/apache/airflow/pull/49195#discussion_r2041213844
##########
airflow-core/src/airflow/utils/hashlib_wrapper.py:
##########
@@ -24,11 +24,11 @@
from _typeshed import ReadableBuffer
-def md5(__string: ReadableBuffer = b"") -> hashlib._Hash:
+def md5(string: ReadableBuffer = b"", /) -> hashlib._Hash:
"""
Safely allows calling the ``hashlib.md5`` function when
``usedforsecurity`` is disabled in configuration.
- :param __string: The data to hash. Default to empty str byte.
+ :param string: The data to hash. Default to empty str byte.
:return: The hashed value.
"""
- return hashlib.md5(__string, usedforsecurity=False) # type: ignore
+ return hashlib.md5(string, usedforsecurity=False) # type: ignore
Review Comment:
## Use of a broken or weak cryptographic hashing algorithm on sensitive data
[Sensitive data (id)](1) is used in a hashing algorithm (MD5) that is
insecure.
[Sensitive data (id)](2) is used in a hashing algorithm (MD5) that is
insecure.
[Sensitive data (id)](3) is used in a hashing algorithm (MD5) that is
insecure.
[Sensitive data (id)](4) is used in a hashing algorithm (MD5) that is
insecure.
[Sensitive data (id)](5) is used in a hashing algorithm (MD5) that is
insecure.
[Sensitive data (id)](6) is used in a hashing algorithm (MD5) that is
insecure.
[Sensitive data (id)](7) is used in a hashing algorithm (MD5) that is
insecure.
[Sensitive data (secret)](8) is used in a hashing algorithm (MD5) that is
insecure.
[Sensitive data (secret)](9) is used in a hashing algorithm (MD5) that is
insecure.
[Sensitive data (id)](10) is used in a hashing algorithm (MD5) that is
insecure.
[Show more
details](https://github.com/apache/airflow/security/code-scanning/463)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
