ashb commented on code in PR #49234:
URL: https://github.com/apache/airflow/pull/49234#discussion_r2042484191


##########
airflow-core/src/airflow/models/variable.py:
##########
@@ -302,7 +302,7 @@ def update(
             )
 
     @staticmethod
-    def delete(key: str, session: Session | None = None) -> int:
+    def delete(key: str, session: Session | None = None) -> None | int:

Review Comment:
   For sake of easier types, why not have this always return `1` on the compat 
path?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to