uranusjr commented on code in PR #49388:
URL: https://github.com/apache/airflow/pull/49388#discussion_r2050295911


##########
providers/amazon/pyproject.toml:
##########
@@ -79,6 +79,7 @@ dependencies = [
     # We can remove it after 
https://github.com/xmlsec/python-xmlsec/issues/344 is fixed
     "xmlsec!=1.3.15,>=1.3.14",
     "sagemaker-studio>=1.0.9",
+    "marshmallow>=3",

Review Comment:
   The Amazon provider has been using Marshmallow without declaring an explicit 
dependency. This has been working since providers depend on Airflow Core, and 
Core uses Marshmallow in the REST API (prior to 3.0).
   
   With this PR removing Marshmallow entirely from Core, the provider needs to 
declare the dependency explicitly.
   
   (Also, since we did not notice this implicit dependency in time, the Amazon 
provider of a non-up-to-date version may break out of the box if you use it 
with Airflow 3.0. This is unfortunate, but we can’t go back and fix old 
provider releases. At least you can easily fix this by manually installing 
Marshmallow.)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to