dimberman commented on a change in pull request #6373: Depends on
[AIRFLOW-5680] [AIRFLOW-5704] Optimise kubernetes image
URL: https://github.com/apache/airflow/pull/6373#discussion_r336753027
##########
File path: Dockerfile
##########
@@ -174,39 +170,8 @@ RUN if [[ "${APT_DEPS_IMAGE}" == "airflow-apt-deps-ci"
]]; then \
;\
fi
-# TODO: We should think about removing those and moving them into
docker-compose dependencies.
COPY scripts/ci/docker_build/ci_build_install_deps.sh
/tmp/ci_build_install_deps.sh
-# Kubernetes dependencies
-RUN \
-if [[ "${APT_DEPS_IMAGE}" == "airflow-apt-deps-ci" ]]; then \
Review comment:
So is the idea here to remove these from the CI image and place them in the
build script so they are loaded at run-time? I'm not sure what we gain from
that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
