guan404ming commented on code in PR #49475:
URL: https://github.com/apache/airflow/pull/49475#discussion_r2055484871
##########
airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/Logs.tsx:
##########
@@ -94,6 +98,17 @@ export const Logs = () => {
tryNumber={tryNumber}
wrap={wrap}
/>
+ {showExternalLogRedirect && externalLogName && taskInstance ? (
+ tryNumber === undefined ? (
+ <p>No try number</p>
+ ) : (
Review Comment:
I believe we should keep that check in place, since
`useTaskInstanceServiceGetExternalLogUrl` is called within `externalLogLink`.
If we pass an undefined `tryNumber`, it might cause
`useTaskInstanceServiceGetExternalLogUrl` to be called conditionally, which we
may want to avoid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
