kaxil commented on code in PR #49758:
URL: https://github.com/apache/airflow/pull/49758#discussion_r2059621844
##########
dev/breeze/src/airflow_breeze/params/shell_params.py:
##########
@@ -539,9 +539,7 @@ def env_variables_for_docker_commands(self) -> dict[str,
str]:
"airflow.providers.edge3.executors.edge_executor.EdgeExecutor",
)
_set_var(_env, "AIRFLOW__EDGE__API_ENABLED", "true")
- _set_var(
- _env, "AIRFLOW__CORE__INTERNAL_API_SECRET_KEY",
b64encode(os.urandom(16)).decode("utf-8")
Review Comment:
This should be fine since it set as env var. and only used for breeze
start-airflow
##########
providers/edge3/src/airflow/providers/edge3/worker_api/auth.py:
##########
@@ -63,11 +62,10 @@ def jwt_validate(authorization: str) -> dict:
@cache
def jwt_signer() -> JWTSigner:
- clock_grace = conf.getint("core", "internal_api_clock_grace",
fallback=30)
return JWTSigner(
- secret_key=conf.get("core", "internal_api_secret_key"),
- expiration_time_in_seconds=clock_grace,
- leeway_in_seconds=clock_grace,
+ secret_key=conf.get("api_auth", "jwt_secret"),
Review Comment:
This is for Airflow 2 so the original was correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
