pierrejeambrun commented on code in PR #49641:
URL: https://github.com/apache/airflow/pull/49641#discussion_r2060682202
##########
airflow-core/src/airflow/api_fastapi/core_api/datamodels/task_instances.py:
##########
@@ -140,6 +141,7 @@ class TaskInstanceHistoryResponse(BaseModel):
try_number: int
max_tries: int
task_display_name: str
+ dag_display_name: str = Field(validation_alias=AliasPath("dag_run",
"dag_model", "dag_display_name"))
hostname: str | None
Review Comment:
I think this can technically be none, in case the dagrun orm object was
deleted for some reason. (That's not a foreign key with a non nullable field,
its just a plain string on history table, so on TIH I think it's
`dag_display_name: str | None`, even if this seems like an edge case.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
