potiuk commented on a change in pull request #6266: [AIRFLOW-2439] Production
Docker image support including refactoring of build scripts - depends on
[AIRFLOW-5704]
URL: https://github.com/apache/airflow/pull/6266#discussion_r337073470
##########
File path: airflow/contrib/hooks/winrm_hook.py
##########
@@ -204,6 +203,7 @@ def get_conn(self):
try:
if self.password and self.password.strip():
+ # pylint: disable=unexpected-keyword-arg
Review comment:
> > This is exactly what I can do using --copy-from as described above
>
> Are you thinking something like
>
> ```dockerfile
> FROM base as compiler
>
> RUN apt-get install build-essential mysql-dev ...
>
> RUN pip install --local -e '.[$extras]' && pip uninstall --yes
apache-airflow
>
> FROM base as prod
>
> RUN apt-get install libmysql
>
> COPY --from=compiler /home/airflow/.local /home/airflow/.local
> ```
>
> Or have I misunderstood you?
Yep. very close to it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
