amoghrajesh commented on code in PR #49843:
URL: https://github.com/apache/airflow/pull/49843#discussion_r2062926773
##########
providers/microsoft/azure/tests/unit/microsoft/azure/hooks/test_msgraph.py:
##########
@@ -398,20 +398,22 @@ def
test_handle_response_async_when_internal_server_error(self):
with pytest.raises(AirflowException):
asyncio.run(DefaultResponseHandler().handle_response_async(response, None))
- @pytest.mark.db_test
- def
test_when_provider_min_airflow_version_is_2_10_or_higher_remove_obsolete_code(self):
- """
- Once this test starts failing due to the fact that the minimum Airflow
version is now 2.10.0 or higher
- for this provider, you should remove the obsolete code in the
get_proxies method of the
- KiotaRequestAdapterHook and remove this test. This test was added to
make sure to not forget to
- remove the fallback code for backward compatibility with Airflow 2.9.x
which isn't need anymore once
- this provider depends on Airflow 2.10.0 or higher.
- """
- min_airflow_version =
get_provider_min_airflow_version("apache-airflow-providers-microsoft-azure")
-
- # Check if the current Airflow version is 2.10.0 or higher
- if min_airflow_version[0] >= 3 or (min_airflow_version[0] >= 2 and
min_airflow_version[1] >= 10):
- method_source =
inspect.getsource(KiotaRequestAdapterHook.get_proxies)
- raise AirflowProviderDeprecationWarning(
- f"Check TODO's to remove obsolete code in get_proxies
method:\n\r\n\r\t\t\t{method_source}"
- )
+ # TODO: Elad: review this after merging the bump 2.10 PR
+ # We should not have specific provider test block the release
+ # @pytest.mark.db_test
+ # def
test_when_provider_min_airflow_version_is_2_10_or_higher_remove_obsolete_code(self):
+ # """
+ # Once this test starts failing due to the fact that the minimum
Airflow version is now 2.10.0 or higher
+ # for this provider, you should remove the obsolete code in the
get_proxies method of the
+ # KiotaRequestAdapterHook and remove this test. This test was added
to make sure to not forget to
+ # remove the fallback code for backward compatibility with Airflow
2.9.x which isn't need anymore once
+ # this provider depends on Airflow 2.10.0 or higher.
+ # """
+ # min_airflow_version =
get_provider_min_airflow_version("apache-airflow-providers-microsoft-azure")
+ #
+ # # Check if the current Airflow version is 2.10.0 or higher
+ # if min_airflow_version[0] >= 3 or (min_airflow_version[0] >= 2 and
min_airflow_version[1] >= 10):
+ # method_source =
inspect.getsource(KiotaRequestAdapterHook.get_proxies)
+ # raise AirflowProviderDeprecationWarning(
+ # f"Check TODO's to remove obsolete code in get_proxies
method:\n\r\n\r\t\t\t{method_source}"
+ # )
Review Comment:
Lets just mark as xfail instead with the todo?
##########
PROVIDERS.rst:
##########
@@ -145,6 +145,10 @@ classification, whether there are breaking changes, new
features or just bugs co
Upgrading Minimum supported version of Airflow
----------------------------------------------
+.. note::
+
+ The following policy applies for Airflow 2. It has not yet been finalized
for Airflow 3 and subject to changes.
Review Comment:
```suggestion
The following policy applies for Airflow 2. It has not yet been finalized
for Airflow 3 and is subject to changes.
```
##########
PROVIDERS.rst:
##########
@@ -153,8 +157,8 @@ Airflow version to the next MINOR release, when 12 months
passed since the first
MINOR version of Airflow.
For example this means that by default we upgrade the minimum version of
Airflow supported by providers
-to 2.9.0 in the first Provider's release after 8th of April 2025. 8th of April
2024 is the date when the
-first ``PATCHLEVEL`` of 2.9 (2.9.0) has been released.
+to 3.0.0 in the first Provider's release after 22nd of April 2026. 22nd of
April 2025 is the date when the
+first ``PATCHLEVEL`` of 3.0 (2.0.0) has been released.
Review Comment:
```suggestion
first ``MAJOR`` VERSION of 3.0 (3.0.0) was released.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
