vincbeck commented on code in PR #49942: URL: https://github.com/apache/airflow/pull/49942#discussion_r2065925296
########## providers/fab/src/airflow/providers/fab/www/extensions/init_wsgi_middlewares.py: ########## @@ -0,0 +1,42 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from __future__ import annotations + +from typing import TYPE_CHECKING + +from airflow.configuration import conf +from airflow.exceptions import AirflowConfigException +from werkzeug.middleware.proxy_fix import ProxyFix + +if TYPE_CHECKING: + from flask import Flask + + +def init_wsgi_middleware(flask_app: Flask) -> None: + """Handle X-Forwarded-* headers and base_url support.""" + + # Apply ProxyFix middleware + if conf.getboolean("webserver", "ENABLE_PROXY_FIX"): Review Comment: I think it would be better to move this config to `fab` instead of keeping it in `webserver` but I think it is too late since we already cut 3.0.0. Unless we consider it a bug fix and put it in 3.0.X branch, then we could still rename this config? Maybe @potiuk knows better on that question -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
