[
https://issues.apache.org/jira/browse/AIRFLOW-3632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16956440#comment-16956440
]
ASF GitHub Bot commented on AIRFLOW-3632:
-----------------------------------------
acroos commented on pull request #6380: [AIRFLOW-3632] Allow
replace_microseconds in trigger_dag REST reqeust
URL: https://github.com/apache/airflow/pull/6380
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-3632
### Description
Reads the value for `replace_microseconds` from the API's `trigger_dag`
endpoint. This will allow the endpoint to trigger > 1 dag per second.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
-
`TestApiExperimental.test_trigger_dag_for_date_with_replace_microseconds_false`
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> dag_runs endpoint does not allow quick subsequent requests to same DAG
> ----------------------------------------------------------------------
>
> Key: AIRFLOW-3632
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3632
> Project: Apache Airflow
> Issue Type: Bug
> Components: api
> Affects Versions: 1.10.1
> Environment: MacOS and Linux
> Reporter: Alpesh
> Assignee: Alpesh
> Priority: Major
> Labels: easyfix
> Attachments: test_api.sh
>
>
> The experimental API endpoint to start dag runs
> (/dags/<string:dag_id>/dag_runs) does not allow quick subsequent requests to
> run same dag as trigger_dag controller method does not pass
> replace_microseconds argument to trigger_dag method of
> common/experimental/trigger_dag.py.
> The attached shell script runs example_bash_operator in quick successions.
> Only first request is accepted and subsequent requests are rejected with
> message "Run id manual__xxxxxx already exists for dag id
> example_bash_operator"
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
