Lee-W commented on code in PR #49779:
URL: https://github.com/apache/airflow/pull/49779#discussion_r2065968056


##########
airflow-core/newsfragments/49779.significant.rst:
##########
@@ -0,0 +1,20 @@
+SecretCache class has been moved to ``airflow.sdk.execution_time.cache``
+
+* Types of change
+
+  * [ ] Dag changes
+  * [ ] Config changes
+  * [ ] API changes
+  * [ ] CLI changes
+  * [ ] Behaviour changes
+  * [ ] Plugin changes
+  * [ ] Dependency changes
+  * [x] Code interface changes
+
+* Migration rules needed
+
+  * ruff
+
+    * AIR302

Review Comment:
   ```suggestion
       * AIR301
   ```
   
   It's now changed to 301



##########
airflow-core/newsfragments/49779.significant.rst:
##########
@@ -0,0 +1,20 @@
+SecretCache class has been moved to ``airflow.sdk.execution_time.cache``
+
+* Types of change
+
+  * [ ] Dag changes
+  * [ ] Config changes
+  * [ ] API changes
+  * [ ] CLI changes
+  * [ ] Behaviour changes
+  * [ ] Plugin changes
+  * [ ] Dependency changes
+  * [x] Code interface changes
+
+* Migration rules needed
+
+  * ruff
+
+    * AIR302
+
+      * [x] ``airflow.secrets.cache`` → ``airflow.sdk.execution_time.cache``

Review Comment:
   Oh wait, I think we need to list all the things importable in `cache`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to