acroos commented on a change in pull request #6380: [AIRFLOW-3632] Allow
replace_microseconds in trigger_dag REST reqeust
URL: https://github.com/apache/airflow/pull/6380#discussion_r337360103
##########
File path: airflow/www/api/experimental/endpoints.py
##########
@@ -74,8 +75,12 @@ def trigger_dag(dag_id):
return response
+ replace_microseconds = True
+ if 'replace_microseconds' in data:
+ replace_microseconds = to_boolean(data['replace_microseconds'])
+
try:
- dr = trigger.trigger_dag(dag_id, run_id, conf, execution_date)
+ dr = trigger.trigger_dag(dag_id, run_id, conf, execution_date,
replace_microseconds)
Review comment:
I found [this
commit](https://github.com/apache/airflow/commit/b7c828bf094d3aa1eae310979a82addf7e423bb0)
from Feb 2017 that mentions why microseconds were replaced at that time. I
would like to think that isn't still relevant, but I'm not sure to be honest.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
