guan404ming commented on code in PR #49763:
URL: https://github.com/apache/airflow/pull/49763#discussion_r2068973899
##########
airflow-core/src/airflow/ui/src/components/DagActions/RunBackfillForm.tsx:
##########
@@ -39,14 +42,16 @@ type RunBackfillFormProps = {
};
const today = new Date().toISOString().slice(0, 16);
+type BackfillFormProps = DagRunTriggerParams & Omit<BackfillPostBody,
"dag_run_conf">;
+
const RunBackfillForm = ({ dag, onClose }: RunBackfillFormProps) => {
const [errors, setErrors] = useState<{ conf?: string; date?: unknown }>({});
const [unpause, setUnpause] = useState(true);
-
- const { control, handleSubmit, reset, watch } = useForm<BackfillPostBody>({
+ const initialParamsDict = useDagParams(dag.dag_id, true);
+ const { control, handleSubmit, reset, watch } = useForm<BackfillFormProps>({
defaultValues: {
+ conf: "",
Review Comment:
btw I have a small question is that should I resolve the conversation after
making the changes, or should I wait for the reviewer to resolve it? Not sure
about the convention and I think both have its pros and cons, thus to ask the
question.
Thanks in advance for your help!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
