ashb commented on a change in pull request #6377: [AIRFLOW-5589] monitor pods
by labels instead of names
URL: https://github.com/apache/airflow/pull/6377#discussion_r337668858
##########
File path: tests/integration/kubernetes/test_kubernetes_pod_operator.py
##########
@@ -61,7 +72,10 @@ def setUp(self):
'namespace': 'default',
'name': ANY,
'annotations': {},
- 'labels': {'foo': 'bar'}
+ 'labels': {'foo': 'bar',
+ 'exec_date': '2019-01-01T0900000000-4bf747daa',
Review comment:
I wonder if it's worth using a non-standard date format here, rather than
always hashing this label? (Ultimately it doesn't matter much to us as Airflow
I guess.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
