pierrejeambrun commented on code in PR #50165:
URL: https://github.com/apache/airflow/pull/50165#discussion_r2073443957
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py:
##########
@@ -928,3 +928,37 @@ def patch_task_instance(
session.commit()
return TaskInstanceResponse.model_validate(ti)
+
+
+@task_instances_router.delete(
+ task_instances_prefix + "/{task_id}",
+ responses=create_openapi_http_exception_doc([status.HTTP_404_NOT_FOUND]),
+ dependencies=[Depends(requires_access_dag(method="DELETE",
access_entity=DagAccessEntity.TASK_INSTANCE))],
+)
+def delete_task_instance(
+ dag_id: str,
+ dag_run_id: str,
+ task_id: str,
+ session: SessionDep,
+ map_index: int = -1,
+) -> None:
+ """Delete a task instance."""
+ query = select(TI).where(
+ TI.dag_id == dag_id,
+ TI.run_id == dag_run_id,
+ TI.task_id == task_id,
+ )
+
+ if map_index >= 0:
+ query = query.where(TI.map_index == map_index)
+ else:
+ query = query.where(TI.map_index == -1)
Review Comment:
It appears to be the same as:
```suggestion
query = query.where(TI.map_index == map_index)
```
##########
airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_task_instances.py:
##########
@@ -4006,3 +4006,140 @@ def
test_should_return_empty_list_for_updating_same_task_instance_state(
)
assert response.status_code == 200
assert response.json() == {"task_instances": [], "total_entries": 0}
+
+
+class TestDeleteTaskInstance(TestTaskInstanceEndpoint):
+ ENDPOINT_URL =
"/dags/example_python_operator/dagRuns/TEST_DAG_RUN_ID/taskInstances/print_the_context"
+ DAG_ID = "example_python_operator"
+ TASK_ID = "print_the_context"
+ RUN_ID = "TEST_DAG_RUN_ID"
Review Comment:
Move `ENDPOINT_URL` to the end of variable definition, and use f-string to
format the URL with other DAG_ID, TASK_ID, and RUN_ID variables.
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py:
##########
@@ -928,3 +928,37 @@ def patch_task_instance(
session.commit()
return TaskInstanceResponse.model_validate(ti)
+
+
+@task_instances_router.delete(
+ task_instances_prefix + "/{task_id}",
+ responses=create_openapi_http_exception_doc([status.HTTP_404_NOT_FOUND]),
+ dependencies=[Depends(requires_access_dag(method="DELETE",
access_entity=DagAccessEntity.TASK_INSTANCE))],
+)
+def delete_task_instance(
+ dag_id: str,
+ dag_run_id: str,
+ task_id: str,
+ session: SessionDep,
+ map_index: int = -1,
+) -> None:
+ """Delete a task instance."""
+ query = select(TI).where(
+ TI.dag_id == dag_id,
+ TI.run_id == dag_run_id,
+ TI.task_id == task_id,
+ )
+
+ if map_index >= 0:
+ query = query.where(TI.map_index == map_index)
+ else:
+ query = query.where(TI.map_index == -1)
+
+ task_instance = session.scalar(query)
+ if task_instance is None:
+ raise HTTPException(
+ status.HTTP_404_NOT_FOUND,
+ f"Task Instance id {task_id} not found in dag {dag_id} run
{dag_run_id}",
Review Comment:
Similar to other messages in the file.
```suggestion
f"The Task Instance with dag_id: `{dag_id}`, run_id:
`{dag_run_id}`, task_id: `{task_id}` and map_index: {map_index} was not found",
```
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py:
##########
@@ -928,3 +928,37 @@ def patch_task_instance(
session.commit()
return TaskInstanceResponse.model_validate(ti)
+
+
+@task_instances_router.delete(
+ task_instances_prefix + "/{task_id}",
+ responses=create_openapi_http_exception_doc([status.HTTP_404_NOT_FOUND]),
+ dependencies=[Depends(requires_access_dag(method="DELETE",
access_entity=DagAccessEntity.TASK_INSTANCE))],
+)
+def delete_task_instance(
+ dag_id: str,
+ dag_run_id: str,
+ task_id: str,
+ session: SessionDep,
+ map_index: int = -1,
+) -> None:
+ """Delete a task instance."""
+ query = select(TI).where(
+ TI.dag_id == dag_id,
+ TI.run_id == dag_run_id,
+ TI.task_id == task_id,
+ )
+
+ if map_index >= 0:
+ query = query.where(TI.map_index == map_index)
+ else:
+ query = query.where(TI.map_index == -1)
Review Comment:
I see that we have this at other places in the file, could be updated too.
map_index is always defined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
