jroachgolf84 commented on PR #50060:
URL: https://github.com/apache/airflow/pull/50060#issuecomment-2851247943
> Looks good to me.
>
> Just wondering if `last_asset_event_id` and `last_asset_event_timestamp`
shouldn't be flat in the asset model but in a nested object such as:
>
> ```
> "last_asset_event": {
> "id":
> "timestamp":
> }
> ```
>
> (A lighter version of the `AssetEventResponse`)
>
> That's a minor detail but if we later need more fields from the last asset
event, then we will have all those field flats mixed up with the asset model.
I think that makes total sense. I'll go ahead and implement that this
morning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
