dabla commented on code in PR #48866:
URL: https://github.com/apache/airflow/pull/48866#discussion_r2074778493
##########
providers/common/sql/src/airflow/providers/common/sql/operators/generic_transfer.py:
##########
@@ -98,9 +101,7 @@ def __init__(
self.preoperator = preoperator
self.insert_args = insert_args or {}
self.page_size = page_size
- self._paginated_sql_statement_format = kwargs.get(
- "paginated_sql_statement_format", "{} LIMIT {} OFFSET {}"
- )
+ self.paginated_sql_statement_format = paginated_sql_statement_format
or "{} LIMIT {} OFFSET {}"
Review Comment:
I would propose another PR for this problem, and solve in through the
dialects by introducing a paginate_statement_format function which could then
be overridden per dialect when necessary, just like we did the same with the
insert/replace_statement_format functions.
I would propose to do that in a separate PR, and also fix the
[SQLTableCheckOperator](https://github.com/apache/airflow/issues/44135) issue
for Oracle using the same technique.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
